Re: [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur

From: Rafael J. Wysocki
Date: Mon Jun 07 2021 - 07:09:34 EST


On Mon, Jun 7, 2021 at 9:26 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 07-06-21, 09:13, Takashi Iwai wrote:
> > The missing key information is that it's a fix for the recent change
> > for 5.14, i.e.
> > Fixes: c1d6d2fd2f64 ("cpufreq: acpi-cpufreq: Skip initialization if cpufreq driver is present")
> >
> > The change made the module left even if it exits before registering
> > the cpufreq driver object.
>
> The original patch looks buggy to me, I was never able to review it :(
>
> I have replied on the original thread instead.

Well, thanks, but that confused me a bit.

Given the above, I'm going to drop the original patch.

Kyle, please reconsider this approach.