Re: [PATCH net-next] net: macb: Use devm_platform_get_and_ioremap_resource()

[Nicolas Ferre]

On 07/06/2021 at 15:43, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index a0c7b1167dbb..7d2fe13a52f8 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4655,8 +4655,7 @@ static int macb_probe(struct platform_device *pdev)
>          struct macb *bp;
>          int err, val;
>
> -       regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       mem = devm_ioremap_resource(&pdev->dev, regs);
> +       mem = devm_platform_get_and_ioremap_resource(pdev, 0, &regs);
>          if (IS_ERR(mem))
>                  return PTR_ERR(mem);
>
> --
> 2.25.1


--
Nicolas Ferre