Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning

[Geert Uytterhoeven]

Hi Dmitry,

On Wed, Jun 2, 2021 at 6:15 AM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote:
> > On Thu, May 27, 2021 at 2:12 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> > > Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
> > > code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
> > > this dependency.
> > >
> > > Removes this kconfig warning:
> > >
> > > WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> > >   Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> > >   Selected by [y]:
> > >   - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
> > >
> > > Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > > Cc: Michael Schmitz <schmitz@xxxxxxxxxx>
> > > Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx>
> > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > > Cc: linux-input@xxxxxxxxxxxxxxx
> > > Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> > > Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Suggested-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
> >
> > > ---
> > > v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
> > >     to Kconfig.machine (Michael). Thanks.
> >
> > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >
> > I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.
>
> Sure, works for me.
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Thanks,  queue in the m68k for-v5.14 branch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds