Re: [PATCH 1/4] platform/x86: hdaps: Constify static attribute_group struct

[Frank Seidel]

> The only use of hdaps_attribute_group is to pass its address to
> sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> to const attribute_group structs. Make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>

Thanks for the patch and keeping me informed.

Reviewed-by: Frank Seidel <frank@xxxxxxxxxxx>

> ---
>   drivers/platform/x86/hdaps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/hdaps.c b/drivers/platform/x86/hdaps.c
> index a72270932ec3..9996485f5295 100644
> --- a/drivers/platform/x86/hdaps.c
> +++ b/drivers/platform/x86/hdaps.c
> @@ -462,7 +462,7 @@ static struct attribute *hdaps_attributes[] = {
>   	NULL,
>   };
>   
> -static struct attribute_group hdaps_attribute_group = {
> +static const struct attribute_group hdaps_attribute_group = {
>   	.attrs = hdaps_attributes,
>   };
>