Re: [PATCH] dt-bindings: rtc: Add Arm PL031 schema

From: Alexandre Belloni
Date: Mon Jun 07 2021 - 16:20:53 EST


Hello Rob,

On 07/06/2021 14:37:18-0500, Rob Herring wrote:
> The PL031 RTC binding has been in use for a long time, but never got
> documented. Fortunately, it's simple and existing users are consistent.
>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: linux-rtc@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../devicetree/bindings/rtc/arm,pl031.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/arm,pl031.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/arm,pl031.yaml b/Documentation/devicetree/bindings/rtc/arm,pl031.yaml
> new file mode 100644
> index 000000000000..77452c9e9b63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/arm,pl031.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/arm,pl031.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Arm Primecell PL031 Real Time Clock
> +
> +select:
> + properties:
> + compatible:
> + contains:
> + const: arm,pl031
> + required:
> + - compatible
> +
> +allOf:
> + - $ref: rtc.yaml#
> +
> +maintainers:
> + - Rob Herring <robh@xxxxxxxxxx>
> +
> +properties:
> + compatible:
> + items:
> + - const: arm,pl031
> + - const: arm,primecell
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +

As the driver sets the range, it also supports start-date from rtc.yaml
With that added:
Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>


--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com