Re: [PATCH] mm, hugetlb: fix allocation error check and copy func name

[Mike Kravetz]

On 6/4/21 6:06 PM, Mina Almasry wrote:
> The alloc_huge_page_vma() doesn't return error pointers, it returns
> NULL.
> 
> There is an existing migrate_page_copy() which not only copies the page
> contents, but also page state/metadata.  People could get confused that
> 'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same
> functionality.  Rename to 'copy_huge_page()' to make it less likely
> folks get confused.
> 
> Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on
> UFFDIO_COPY")
> 
> Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> 
> ---
>  include/linux/migrate.h | 4 ++--
>  mm/hugetlb.c            | 4 ++--
>  mm/migrate.c            | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

As mentioned by Muchun, Andrew should squash this and original patch.
With the combined patches,

Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
-- 
Mike Kravetz