Re: [PATCH 0/7] fpga: wrappers for fpga_manager_ops

[Moritz Fischer]

Hi Tom,

On Mon, Jun 07, 2021 at 10:23:55AM -0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
> 
> As followup from
> https://lore.kernel.org/linux-fpga/06301910-10a1-0e62-45a0-d28ab5a787ed@xxxxxxxxxx/
> 
> Boards should not be required to have noop functions.
> So improve or create fpga-mgr wrappers for the fpga_manager_ops.  
> Remove the noop functions.
> Refactor fpga-mgr to use the wrappers.
> 
> write_sg op was not wrapped on purpose.  Its checking / use in
> fpga_mgr_buf_load_sg() did not warrant a wrapper.
> 
> Tom Rix (7):
>   fpga: wrap the write_init() op
>   fpga: make write_complete() op optional
>   fpga: wrap the write() op
>   fpga: wrap the status() op
>   fpga: wrap the state() op
>   fpga: wrap the fpga_remove() op
>   fpga: collect wrappers and change to inline
> 
>  drivers/fpga/dfl-fme-mgr.c   |   6 ---
>  drivers/fpga/fpga-mgr.c      | 102 +++++++++++++++++++++++------------
>  drivers/fpga/stratix10-soc.c |   6 ---
>  drivers/fpga/ts73xx-fpga.c   |   6 ---
>  drivers/fpga/zynqmp-fpga.c   |   7 ---
>  5 files changed, 67 insertions(+), 60 deletions(-)
> 
> -- 
> 2.26.3
> 

Thanks for doing this, will take a look tonight!

- Moritz