Re: [PATCH] irq_work: record irq_work_queue() call stack
From: Peter Zijlstra
Date: Tue Jun 08 2021 - 13:51:47 EST
On Wed, Mar 31, 2021 at 02:32:02PM +0800, qiang.zhang@xxxxxxxxxxxxx wrote:
> @@ -70,6 +70,9 @@ bool irq_work_queue(struct irq_work *work)
> if (!irq_work_claim(work))
> return false;
>
> + /*record irq_work call stack in order to print it in KASAN reports*/
> + kasan_record_aux_stack(work);
> +
> /* Queue the entry and raise the IPI if needed. */
> preempt_disable();
> __irq_work_queue_local(work);
Thanks for the Cc :/ Also NAK.
I shall go revert this instantly. KASAN is not NMI safe, while
irq_work_queue() is very carefully crafted to be exactly that.