Re: [PATCH v3 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)

[Konrad Dybcio]

>> +/delete-node/ &hdmi;
>> +/delete-node/ &hdmi_phy;
>> +/delete-node/ &mdp5_intf3_out;
> Is it not enough to set those to status = "disabled"? Kind of strange
> that you have to delete those entirely. I guess ideally "hdmi" should
> even be disabled by default in the SoC device tree.

Saving memory and bloat where possible. Deleting these makes inspecting decompiled

DTBs simpler and allows for ever so slightly bigger kernel images (the boot partition is finite).



>> +
>> +	panel_tvdd: tvdd-regulator {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "panel_tvdd";
>> +		gpio = <&tlmm 50 GPIO_ACTIVE_HIGH>;
> regulator-fixed is active-low without "enable-active-high;"
> If that's what you want it's probably more clear to write
> GPIO_ACTIVE_LOW. Otherwise, perhaps you forgot that property? :)

Interestingly enough it doesn't work *with* the property, but does without :|


Konrad