Re: [PATCH v3 8/9] drivers/perf: Simpilfy EVENT ATTR macro in arm_dsu_pmu.c

[liuqi (BA)]

Hi Will,
On 2021/6/8 16:52, Will Deacon wrote:
> On Tue, Jun 08, 2021 at 11:33:20AM +0800, Qi Liu wrote:
> > Use common macro PMU_EVENT_ATTR_ID to simplify DSU_EVENT_ATTR.
> >
> > Cc: Will Deacon <will@xxxxxxxxxx>
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Signed-off-by: Qi Liu <liuqi115@xxxxxxxxxx>
> > ---
> >   drivers/perf/arm_dsu_pmu.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
> > index 196faea..bed8376 100644
> > --- a/drivers/perf/arm_dsu_pmu.c
> > +++ b/drivers/perf/arm_dsu_pmu.c
> > @@ -82,7 +82,7 @@
> >   	})[0].attr.attr)
> >   
> >   #define DSU_EVENT_ATTR(_name, _config)		\
> > -	DSU_EXT_ATTR(_name, dsu_pmu_sysfs_event_show, (unsigned long)_config)
> > +	PMU_EVENT_ATTR_ID(_name, dsu_pmu_sysfs_event_show, _config)
> >   
> >   #define DSU_FORMAT_ATTR(_name, _config)		\
> >   	DSU_EXT_ATTR(_name, dsu_pmu_sysfs_format_show, (char *)_config)
>
> I'm not convinced this is any simpler. We still have two users of the
> DSU_EXT_ATTR macro and the net effect is no change in line count.
Got it, I'll drop this patch and sent a new patchset.

Thanks,
Qi
> Will
> .