Re: [PATCH] mm: compaction: remove duplicate !list_empty(&sublist) check

[David Hildenbrand]

On 09.06.21 11:54, Liu Xiang wrote:
> The list_splice_tail(&sublist, freelist) also do
> !list_empty(&sublist) check, so remove the duplicate call.
>
> Signed-off-by: Liu Xiang <liu.xiang@xxxxxxxxxxxxxx>
> ---
>   mm/compaction.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 84fde270a..5b1dc832f 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1297,8 +1297,7 @@ move_freelist_head(struct list_head *freelist, struct page *freepage)
>   
>   	if (!list_is_last(freelist, &freepage->lru)) {
>   		list_cut_before(&sublist, freelist, &freepage->lru);
> -		if (!list_empty(&sublist))
> -			list_splice_tail(&sublist, freelist);
> +		list_splice_tail(&sublist, freelist);
>   	}
>   }
>   
> @@ -1315,8 +1314,7 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage)
>   
>   	if (!list_is_first(freelist, &freepage->lru)) {
>   		list_cut_position(&sublist, freelist, &freepage->lru);
> -		if (!list_empty(&sublist))
> -			list_splice_tail(&sublist, freelist);
> +		list_splice_tail(&sublist, freelist);
>   	}
>   }
>   

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb