Re: [PATCH 31/31] arm64: zynqmp: Add support for Xilinx Kria SOM board

[Geert Uytterhoeven]

Hi Michal,

On Wed, Jun 9, 2021 at 1:46 PM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
> There are couple of revisions of SOMs (k26) and associated carrier cards
> (kv260).
> SOM itself has two major versions:
> sm-k26 - SOM with EMMC
> smk-k26 - SOM without EMMC used on starter kit with preprogrammed firmware
> in QSPI.
>
> SOMs are describing only devices available on the SOM or connections which
> are described in specification (for example UART, fwuen).
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks for your patch!

> --- /dev/null
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-sck-kv-g-revA.dts
> @@ -0,0 +1,371 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * dts file for KV260 revA Carrier Card
> + *
> + * (C) Copyright 2020, Xilinx, Inc.
> + *
> + * SD level shifter:
> + * "A" – A01 board un-modified (NXP)
> + * "Y" – A01 board modified with legacy interposer (Nexperia)
> + * "Z" – A01 board modified with Diode interposer
> + *
> + * Michal Simek <michal.simek@xxxxxxxxxx>
> + */
> +
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/net/ti-dp83867.h>
> + #include <dt-bindings/phy/phy.h>
> + #include <dt-bindings/pinctrl/pinctrl-zynqmp.h>
> +
> +/dts-v1/;
> +/plugin/;
> +
> +/{
> +       compatible = "xlnx,zynqmp-sk-kv260-revA",
> +                    "xlnx,zynqmp-sk-kv260-revY",
> +                    "xlnx,zynqmp-sk-kv260-revZ",
> +                    "xlnx,zynqmp-sk-kv260", "xlnx,zynqmp";
> +
> +       fragment1 {
> +               target = <&i2c1>; /* I2C_SCK C23/C24 - MIO from SOM */
> +
> +               __overlay__ {

Please use overlay sugar syntax, which is supported by the dtc
supplied with the kernel since v4.15.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds