Re: [PATCH v7 1/4] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'
From: Jarkko Sakkinen
Date: Wed Jun 09 2021 - 09:00:45 EST
On Mon, Jun 07, 2021 at 09:28:56AM -0700, Reinette Chatre wrote:
> Hi Jarkko,
>
> On 5/26/2021 5:47 AM, Jarkko Sakkinen wrote:
> > diff --git a/tools/testing/selftests/sgx/main.h b/tools/testing/selftests/sgx/main.h
> > index 67211a708f04..68672fd86cf9 100644
> > --- a/tools/testing/selftests/sgx/main.h
> > +++ b/tools/testing/selftests/sgx/main.h
> > @@ -35,7 +35,7 @@ bool encl_load(const char *path, struct encl *encl);
> > bool encl_measure(struct encl *encl);
> > bool encl_build(struct encl *encl);
> > -int sgx_call_vdso(void *rdi, void *rsi, long rdx, u32 function, void *r8, void *r9,
> > - struct sgx_enclave_run *run);
> > +int sgx_enter_enclave(void *rdi, void *rsi, long rdx, u32 function, void *r8, void *r9,
> > + struct sgx_enclave_run *run);
>
> Is there a reason why all registers except rdx are "void *"?
Evolution? It's test code.
There's neither reason to change this for no reason.
/Jarkko