Re: [PATCH 17/17] media: dt-bindings: media: camss: Add qcom,sm8250-camss binding

[Jonathan Marek]

On 6/9/21 6:10 PM, Rob Herring wrote:
> On Tue, Jun 08, 2021 at 06:35:06PM -0400, Jonathan Marek wrote:
> > Add bindings for qcom,sm8250-camss in order to support the camera
> > subsystem for SM8250.

...

> > +    items:
> > +      - const: csiphy0
> > +      - const: csiphy1
> > +      - const: csiphy2
> > +      - const: csiphy3
> > +      - const: csiphy4
> > +      - const: csiphy5
>
> Should be separate phy nodes? Same/similar DPHY or CPHY as QCom DSI PHY?

This is not a new driver, this series only adds support for a new SoC - 
the design has already been decided (and this binding is similar to 
qcom,sdm845-camss.yaml).

The hardware supports D-PHY and C-PHY, but the driver isn't aware of 
this and assumes D-PHY. sdm845 and msm8996 hardware also support C-PHY, 
so it isn't a problem specific to this series.

> > +      - const: vfe0
> > +      - const: vfe1
> > +      - const: vfe_lite0
> > +      - const: vfe_lite1
> > +