Re: [PATCH v3 1/4] usb: xhci-mtk: use bitfield instead of bool

[Ikjoon Jang]

On Fri, May 7, 2021 at 10:11 AM Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote:
>
> Use bitfield instead of bool in struct
>
> Refer to coding-style.rst 17) Using bool:
> "If a structure has many true/false values, consider consolidating
> them into a bitfield with 1 bit members, or using an appropriate
> fixed width type, such as u8."
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>

Reviewed-and-Tested-by: Ikjoon Jang <ikjn@xxxxxxxxxxxx>

> ---
> v3: split @has_ippc out into anather patch suggested by Greg
> v2: add more changelog suggested by Greg
> ---
>  drivers/usb/host/xhci-mtk.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.h b/drivers/usb/host/xhci-mtk.h
> index cd3a37bb73e6..94a59b3d178f 100644
> --- a/drivers/usb/host/xhci-mtk.h
> +++ b/drivers/usb/host/xhci-mtk.h
> @@ -138,17 +138,17 @@ struct xhci_hcd_mtk {
>         struct mu3h_sch_bw_info *sch_array;
>         struct list_head bw_ep_chk_list;
>         struct mu3c_ippc_regs __iomem *ippc_regs;
> -       bool has_ippc;
>         int num_u2_ports;
>         int num_u3_ports;
>         int u3p_dis_msk;
>         struct regulator *vusb33;
>         struct regulator *vbus;
>         struct clk_bulk_data clks[BULK_CLKS_NUM];
> -       bool lpm_support;
> -       bool u2_lpm_disable;
> +       unsigned int has_ippc:1;
> +       unsigned int lpm_support:1;
> +       unsigned int u2_lpm_disable:1;
>         /* usb remote wakeup */
> -       bool uwk_en;
> +       unsigned int uwk_en:1;
>         struct regmap *uwk;
>         u32 uwk_reg_base;
>         u32 uwk_vers;
> --
> 2.18.0
>