Re: 答复: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[NFBAI]

Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> 于2021年6月8日周二 下午8:08写道：
>
>
> Nianfu,
>
> On 08/06/2021 04:55, 柏年福 (Nianfu Bai) wrote:
> > On 11/05/2021 09:08, Nianfu Bai wrote:
> >> From: Nianfu Bai <nianfu.bai@xxxxxxxxxx>
> >>
> >> Tick broadcast installed by insmod cannot switch to oneshot mode correctly
> >> caused by linux timer framework, need to build in kernel image.
> >
> > What timer is compiled as a module?
> >> We want to compile sprd timer  as a module.
> >
> > Why the timer framework does not allow to switch to it ?
> >> Pls refer to the patch description deblow:
> > https://lore.kernel.org/lkml/161860007587.29796.7100262021118685563.tip-bot2@tip-bot2/
>
> Thanks for the pointer I understand the bug.
>
> However the description does not refer to this fix. It tells the timer
> is a module and then tells it depends on the sprd arch.
>
> What are the connection between all these points?
As https://lore.kernel.org/lkml/161860007587.29796.7100262021118685563.tip-bot2@tip-bot2/
description, sprd timer can not build as a module, we have to build
sprd timer in kernel image, but the sprd timer is depend on sprd arch,
we do not want to enable sprd arch config when build sprd timer in
kernel image, so we need to remove the dependency between sprd timer
and sprd arch.


>
> On the other side, the email format is not text, replies are not
> correctly put inline, it is hard to follow the discussion.
>
> Please, take the time to read the documentation about submitting patches
> [1] and then provide a clear Changelog, no need to refer the timer is
> loaded after because it is a module, the Kconfig says the opposite.
>
> Thanks
>
>   -- Daniel
>
> [1] Documentation/process/*
>
> >> SPRD_TIMER
> >> has been selected by SPRD arch, we have to enable SPRD arch when we build
> >> sprd timer in kernel image, this action conflicts with general kernel image,
> >
> > Why this is conflicting with general kernel image?
> >
> >> so we need to remove the dependency between sprd timer and SPRD arch.
> >
> > Can you rephrase the changelog, I'm not getting the point.
> >
> >> Signed-off-by: Nianfu Bai <nianfu.bai@xxxxxxxxxx>
> >> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@xxxxxxxxxx>
> >> ---
> >>  drivers/clocksource/Kconfig | 4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> >> index 39aa21d..04b333c 100644
> >> --- a/drivers/clocksource/Kconfig
> >> +++ b/drivers/clocksource/Kconfig
> >> @@ -447,10 +447,8 @@ config MTK_TIMER
> >>         Support for Mediatek timer driver.
> >>
> >>  config SPRD_TIMER
> >> -     bool "Spreadtrum timer driver" if EXPERT
> >> +     bool "Spreadtrum timer driver" if COMPILE_TEST
> >>       depends on HAS_IOMEM
> >> -     depends on (ARCH_SPRD || COMPILE_TEST)
> >> -     default ARCH_SPRD
> >>       select TIMER_OF
> >>       help
> >>         Enables support for the Spreadtrum timer driver.
> >>
> >
> >
> > --
> > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> >
> > Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> > <http://twitter.com/#!/linaroorg> Twitter |
> > <http://www.linaro.org/linaro-blog/> Blog
> > ________________________________
> >  This email (including its attachments) is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorized use, dissemination, distribution or copying of this email or the information herein or taking any action in reliance on the contents of this email or the information herein, by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is strictly prohibited. If you are not the intended recipient, please do not read, copy, use or disclose any part of this e-mail to others. Please notify the sender immediately and permanently delete this e-mail and any attachments if you received it in error. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender does not accept liability for any errors or omissions.
> > 本邮件及其附件具有保密性质，受法律保护不得泄露，仅发送给本邮件所指特定收件人。严禁非经授权使用、宣传、发布或复制本邮件或其内容。若非该特定收件人，请勿阅读、复制、 使用或披露本邮件的任何内容。若误收本邮件，请从系统中永久性删除本邮件及所有附件，并以回复邮件的方式即刻告知发件人。无法保证互联网通信及时、安全、无误或防毒。发件人对任何错漏均不承担责任。
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog