Re: [PATCH v3 4/4] tty: make use of tty_get_{char,frame}_size

[Alex Elder]

On 6/10/21 4:02 AM, Jiri Slaby wrote:
> In the previous patch, we introduced tty_get_char_size() and
> tty_get_frame_size() for computing character and frame sizes,
> respectively. Here, we make use of them in various tty drivers where
> applicable.
>
> The stats look nice: 12 insertions, 169 deletions.

Agreed.  Looks good to me (for drivers/staging/greybus/uart.c).

Acked-by: Alex Elder <elder@xxxxxxxxxx>

> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: David Lin <dtwlin@xxxxxxxxx>
> Cc: Johan Hovold <johan@xxxxxxxxxx>
> Cc: Alex Elder <elder@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Andy Gross <agross@xxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Cc: Oliver Neukum <oneukum@xxxxxxxx>