Re: [PATCH v36 1/4] scsi: ufs: Introduce HPB feature

From: Bart Van Assche
Date: Thu Jun 10 2021 - 12:45:57 EST


On 6/6/21 9:17 PM, Daejun Park wrote:
> +What: /sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt
> +Date: June 2021
> +Contact: Daejun Park <daejun7.park@xxxxxxxxxxx>
> +Description: This entry shows the number of reads that changed to HPB read.
> +
> + The file is read only.

This patch introduces the hit_cnt attribute in the hpb_sysfs directory
and patch 4 moves that attribute to the hpb_stats directory. That is not
how sysfs attributes should be introduced. Please introduce the hit_cnt
attribute in the hpb_stats directory in this patch such that the sysfs
directory does not have to be modified in patch 4.

Thanks,

Bart.