Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver

From: Grant Likely
Date: Thu Jun 10 2021 - 14:28:23 EST


On 10/06/2021 19:25, Rafael J. Wysocki wrote:
On Thu, Jun 10, 2021 at 7:51 PM Jon Nettleton <jon@xxxxxxxxxxxxx> wrote:

On Thu, Jun 10, 2021 at 6:56 PM Andrew Lunn <andrew@xxxxxxx> wrote:

On Thu, Jun 10, 2021 at 07:39:02PM +0300, Ioana Ciornei wrote:
From: Ioana Ciornei <ioana.ciornei@xxxxxxx>

This patch set provides ACPI support to DPAA2 network drivers.

Just to be clear and avoid confusion, there is a standing NACK against
this patchset. Please see the discussion here:

https://patchwork.kernel.org/project/linux-acpi/patch/20200715090400.4733-2-calvin.johnson@xxxxxxxxxxx/#23518385

So far, i've not seen any indication the issues raised there have been
resolved. I don't see any Acked-by from an ACPI maintainer. So this
code remains NACKed.

Andrew,

The ACPI maintainers did bless the use of the ACPI standards followed
in this patchset, and their only abstinence from ACK'ing the patchset
was whether the code was used in production systems. Well currently,
not only have we, SolidRun, been using this patchset and the associated
ACPI tables in our SystemsReady certified firmware for the HoneyComb,
but we also have customers using this same patchset and firmware on
their systems rolled out to customers.

Additionally we have an entire new product line based on Marvell's
Armada CN913x series, which also needs this patchset to be fully
functional.

I am quite certain this is more than enough production systems using
this ACPI description method for networking to progress this patchset
forward.

And I believe that you have all of the requisite ACKs from the ACPI
side now, so it is up to the networking guys to decide what to do
next.

You've also my ACK as emeritus Devicetree maintainer. It is well past time for this series to get merged.

g.