Re: [PATCH net-next v8 12/15] net/fsl: Use [acpi|of]_mdiobus_register

[Andy Shevchenko]

On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei <ciorneiioana@xxxxxxxxx> wrote:
>
> From: Calvin Johnson <calvin.johnson@xxxxxxxxxxx>
>
> Depending on the device node type, call the specific OF or ACPI
> mdiobus_register function.
>
> Note: For both ACPI and DT cases, endianness of MDIO controller

controllers

> need to be specified using "little-endian" property.

using the

...

> Changes in v8:
> - Directly call the OF or ACPI variants of registering the MDIO bus.
>   This is needed because the fwnode_mdio.c module should only implement
>   features which can be achieved without going back to the OF/ACPI
>   variants. Without this restrictions we directly end up in a dependency
>   cycle: of_mdio -> fwnode_mdio -> of_mdio.

Shouldn't be simple fwnode_mdio.h.
The idea of fwnode APIs that they provide a common ground for all
resource providers.

> - Changed the commit title since the fwnode_mdiobus_register() is no
>   longer available
>
> Changes in v7:
> - Include fwnode_mdio.h

> - Alphabetically sort header inclusions

I suppose this should be a separate change.


-- 
With Best Regards,
Andy Shevchenko