Re: [PATCH 5/9] nvmem: core: add a missing of_node_put

From: Srinivas Kandagatla
Date: Fri Jun 11 2021 - 05:11:33 EST




On 11/06/2021 09:57, Greg KH wrote:
On Fri, Jun 11, 2021 at 09:33:44AM +0100, Srinivas Kandagatla wrote:
From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

'for_each_child_of_node' performs an of_node_get on each iteration, so a
return from the middle of the loop requires an of_node_put.

Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
---
drivers/nvmem/core.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

Looks like this needs to go to the stable kernel trees, so when your
resend this series, please add the proper "cc: stable" line to the
signed-off-by area as is documented.

I agree, I missed that, will resend this one out with cc: Stable


--srini

thanks,

greg k-h