Re: [PATCH v3 1/2] dt-bindings: mediatek: convert mtk jpeg decoder/encoder to yaml

From: Matthias Brugger
Date: Fri Jun 11 2021 - 05:49:36 EST




On 11/06/2021 11:23, Hsin-Yi Wang wrote:
> Convert mediatek jpeg decoder and encoder bindings to yaml.>
[...]
> diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> new file mode 100644
> index 0000000000000..e4e791d76cdaa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek-jpeg-encoder.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek JPEG Encoder Device Tree Bindings
> +
> +maintainers:
> + - Xia Jiang <xia.jiang@xxxxxxxxxxxx>
> +
> +description: |-
> + MediaTek JPEG Encoder is the JPEG encode hardware present in MediaTek SoCs
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - mediatek,mt2701-jpgenc
> + - mediatek,mt8183-jpgenc

Commit message talks about conversion. Sorry for nit-picking, but I think the
new compatible should get a new patch. If you add changes to a file while
converting/moving it, it get's really hard to find that change later on.

Regards,
Matthias