Re: [PATCH v2] dt-bindings: rtc: zynqmp: convert bindings to YAML

[Nobuhiro Iwamatsu]

Hi,

Thanks for your review.

2021年6月11日(金) 2:21 Rob Herring <robh@xxxxxxxxxx>:
>
> On Wed, Jun 02, 2021 at 09:09:18AM +0900, Nobuhiro Iwamatsu wrote:
> > Convert Real Time Clock for Xilinx Zynq MPSoC SoC bindings documentation
> > to YAML schemas.
> > And this renamed the file to compatible string of DT.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@xxxxxxxxxxx>
> > ---
> >
> > v2: Fix warning with DT_CHECKER_FLAGS=-m
> >
> >  .../bindings/rtc/xlnx,zynqmp-rtc.yaml         | 61 +++++++++++++++++++
> >  .../devicetree/bindings/rtc/xlnx-rtc.txt      | 25 --------
> >  2 files changed, 61 insertions(+), 25 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/rtc/xlnx-rtc.txt
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> > new file mode 100644
> > index 00000000000000..c205cb86ef00be
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/xlnx,zynqmp-rtc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Xilinx Zynq Ultrascale+ MPSoC Real Time Clock
> > +
> > +description: |
>
> Don't need '|'

OK, I will drop.

>
> > +  RTC controller for the Xilinx Zynq MPSoC Real Time Clock.
> > +  This separates IRQ lines for seconds and alarm.
>
> The RTC controller has separate IRQ...

I will update description, thanks.

>
> > +
> > +maintainers:
> > +  - Michal Simek <michal.simek@xxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: rtc.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: xlnx,zynqmp-rtc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    minItems: 2
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: alarm
> > +      - const: sec
> > +
> > +  calibration:
> > +    description: |
> > +      calibration value for 1 sec period which will
> > +      be programmed directly to calibration register.
>
> Needs a type $ref.

OK, I will add $ref.

>
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - interrupt-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +      #address-cells = <2>;
> > +      #size-cells = <2>;
> > +
> > +      rtc: rtc@ffa60000 {
> > +        compatible = "xlnx,zynqmp-rtc";
> > +        reg = <0x0 0xffa60000 0x0 0x100>;
> > +        interrupt-parent = <&gic>;
> > +        interrupts = <0 26 4>, <0 27 4>;
> > +        interrupt-names = "alarm", "sec";
> > +        calibration = <0x198233>;
> > +      };
> > +    };

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6