Re: [PATCH 5/6] staging: rtl8188eu: remove DebugComponents/DebugLevel from odm_dm_struct

[Phillip Potter]

On Fri, Jun 11, 2021 at 12:08:19PM +0300, Dan Carpenter wrote:
> On Fri, Jun 11, 2021 at 01:25:03AM +0100, Phillip Potter wrote:
> > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> > index 80cdcf6f7879..3e7f184ed39a 100644
> > --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> > +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> > @@ -1851,11 +1851,6 @@ u8 rtw_hal_get_def_var(struct adapter *Adapter, enum hal_def_variable eVariable,
> >  		}
> >  		break;
> >  	case HW_DEF_ODM_DBG_FLAG:
> > -		{
> > -			struct odm_dm_struct *dm_ocm = &haldata->odmpriv;
> > -
> > -			pr_info("dm_ocm->DebugComponents = 0x%llx\n", dm_ocm->DebugComponents);
> > -		}
> >  		break;
> 
> We will want to delete everything to do with ODM_DBG_FLAG but that can
> be done in later patches.
> 
> regards,
> dan carpenter
> 
Dear Dan,

Thanks, yeah I considered taking this clause out of the switch
completely, but I wanted to keep the patch set focused just to removal
of odm_debug.h - I'll get this done next :-) Thanks for your feedback.

Regards,
Phil