[tip:tmp.tmp2 12/364] include/asm-generic/preempt.h:69:36: error: implicit declaration of function 'tif_need_resched'

From: kernel test robot
Date: Sun Jun 13 2021 - 16:36:23 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.tmp2
head: adcceb5eb7aee38e4a9c15bdf599655f0e1b1324
commit: 40962503e2b9bddcef82fba70374b464ee9867b1 [12/364] sched/headers: Move thread_info APIs to <linux/sched/thread_info_api.h>
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=40962503e2b9bddcef82fba70374b464ee9867b1
git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
git fetch --no-tags tip tmp.tmp2
git checkout 40962503e2b9bddcef82fba70374b464ee9867b1
# save the attached .config to linux build tree
make W=1 ARCH=um SUBARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from ./arch/um/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:80,
from include/linux/rcupdate.h:29,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:16,
from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
from arch/um/kernel/asm-offsets.c:1:
include/asm-generic/preempt.h: In function '__preempt_count_dec_and_test':
>> include/asm-generic/preempt.h:69:36: error: implicit declaration of function 'tif_need_resched' [-Werror=implicit-function-declaration]
69 | return !--*preempt_count_ptr() && tif_need_resched();
| ^~~~~~~~~~~~~~~~
In file included from arch/um/kernel/asm-offsets.c:1:
arch/x86/um/shared/sysdep/kernel-offsets.h: At top level:
arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
cc1: some warnings being treated as errors
--
arch/x86/um/user-offsets.c:18:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
18 | void foo(void)
| ^~~
In file included from ./arch/um/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:80,
from include/linux/rcupdate.h:29,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:16,
from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
from arch/um/kernel/asm-offsets.c:1:
include/asm-generic/preempt.h: In function '__preempt_count_dec_and_test':
>> include/asm-generic/preempt.h:69:36: error: implicit declaration of function 'tif_need_resched' [-Werror=implicit-function-declaration]
69 | return !--*preempt_count_ptr() && tif_need_resched();
| ^~~~~~~~~~~~~~~~
In file included from arch/um/kernel/asm-offsets.c:1:
arch/x86/um/shared/sysdep/kernel-offsets.h: At top level:
arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:117: arch/um/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1232: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
arch/x86/um/user-offsets.c:18:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
18 | void foo(void)
| ^~~
In file included from ./arch/um/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:80,
from include/linux/rcupdate.h:29,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:16,
from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
from arch/um/kernel/asm-offsets.c:1:
include/asm-generic/preempt.h: In function '__preempt_count_dec_and_test':
>> include/asm-generic/preempt.h:69:36: error: implicit declaration of function 'tif_need_resched' [-Werror=implicit-function-declaration]
69 | return !--*preempt_count_ptr() && tif_need_resched();
| ^~~~~~~~~~~~~~~~
In file included from arch/um/kernel/asm-offsets.c:1:
arch/x86/um/shared/sysdep/kernel-offsets.h: At top level:
arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:117: arch/um/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1232: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.


vim +/tif_need_resched +69 include/asm-generic/preempt.h

bdb43806589096 Peter Zijlstra 2013-09-10 61
bdb43806589096 Peter Zijlstra 2013-09-10 62 static __always_inline bool __preempt_count_dec_and_test(void)
bdb43806589096 Peter Zijlstra 2013-09-10 63 {
ba1f14fbe70965 Peter Zijlstra 2013-11-28 64 /*
ba1f14fbe70965 Peter Zijlstra 2013-11-28 65 * Because of load-store architectures cannot do per-cpu atomic
ba1f14fbe70965 Peter Zijlstra 2013-11-28 66 * operations; we cannot use PREEMPT_NEED_RESCHED because it might get
ba1f14fbe70965 Peter Zijlstra 2013-11-28 67 * lost.
ba1f14fbe70965 Peter Zijlstra 2013-11-28 68 */
ba1f14fbe70965 Peter Zijlstra 2013-11-28 @69 return !--*preempt_count_ptr() && tif_need_resched();
bdb43806589096 Peter Zijlstra 2013-09-10 70 }
bdb43806589096 Peter Zijlstra 2013-09-10 71

:::::: The code at line 69 was first introduced by commit
:::::: ba1f14fbe70965ae0fb1655a5275a62723f65b77 sched: Remove PREEMPT_NEED_RESCHED from generic code

:::::: TO: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
:::::: CC: Ingo Molnar <mingo@xxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip