Re: [PATCH 6/6] staging: rtl8188eu: remove RT_TRACE and DBG_88E prints from usb_intf.c

From: Dan Carpenter
Date: Mon Jun 14 2021 - 07:43:12 EST


On Sat, Jun 12, 2021 at 08:00:19PM +0200, Martin Kaiser wrote:
> These prints are disabled by default.
>

Not, just by default. There is literally no way to enable them.

> Replace the print after dev_alloc_name with proper error handling.
>

Ugh... :( This part really needs to be done first and in a separate
patch. You can delete the RT_TRACE() from that one call site since it's
on the same line but the subject of the patch needs to say something
like "check for allocation failure". It can't be "remove RT_TRACE and
DBG_88E prints".

The first five of these patch look good though.

regards,
dan carpenter