Re: [PATCH] docs: fault-injection: fix non-working usage of negative values

From: Jonathan Corbet
Date: Mon Jun 14 2021 - 17:59:10 EST


Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> writes:

> Fault injection uses debugfs in a way that the provided values via sysfs
> are interpreted as u64. Providing negative numbers results in an error:
>
> /sys/kernel/debug/fail_function# echo -1 > times
> sh: write error: Invalid argument
>
> Update the docs and examples to use "printf %#x <val>" in these cases.
> For "retval", reword the paragraph a little and fix a typo.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> .../fault-injection/fault-injection.rst | 24 +++++++++++--------
> 1 file changed, 14 insertions(+), 10 deletions(-)

Applied, thanks.

jon