Re: [PATCH] ssb: Remove redundant assignment to err

From: Kalle Valo
Date: Tue Jun 15 2021 - 06:10:52 EST


Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:

> Variable 'err' is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Clean up the following clang-analyzer warning:
>
> drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
> drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> Acked-by: Michael Büsch <m@xxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

7557dfde1bd1 ssb: Remove redundant assignment to err

--
https://patchwork.kernel.org/project/linux-wireless/patch/1619693230-108804-1-git-send-email-yang.lee@xxxxxxxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches