Re: [PATCH][next] mtd: devices: mchp48l640: Fix return of uninitialized value in ret

From: Heiko Schocher
Date: Tue Jun 15 2021 - 11:38:14 EST


Hello Colin,

On 15.06.21 16:06, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the case where the read or write lengths are zero bytes the return
> value in variable ret has not been initialized and a garbage value
> is returned. Fix this by initializing ret to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/mtd/devices/mchp48l640.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@xxxxxxx>

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@xxxxxxx