Re: [PATCH v2 00/15] misc: nnpi: New PCIe driver for Intel's NNP-I pcie device

[Greg KH]

On Tue, Jun 15, 2021 at 05:58:09PM +0300, Guy Zadicario wrote:
> On Fri, May 14, 2021 at 11:33:31AM +0300, Greg KH wrote:
> > On Thu, May 13, 2021 at 11:57:10AM +0300, Guy Zadicario wrote:
> > > Hi,
> > > 
> > > The following series is a driver for a new PCIe device from Intel named NNP-I
> > > (Nirvana Neural Processor for Inference). NNP-I is a PCIe connected compute
> > > device used for acceleration of AI deep learning inference applications in the
> > > data-center.
> > 
> > How does this differ from the "intel_gna" driver being proposed here:
> > 	https://lore.kernel.org/linux-doc/20210513110040.2268-1-maciej.kwapulinski@xxxxxxxxxxxxxxx/
> > 
> > Please work together to come up with a unified userspace api for these
> > devices, and hopefully, shared kernel code as well.
> > 
> Ok, after consulting, we will try to share api and some kernel code
> between the two drivers.
> 
> The plan is to suggest a common framework for both devices
> and let each device driver register with that framework,
> some functionality will be common and some will be device driver
> specific (same model as drm for gpus). At first I think the common part
> will be small and will deal only with host memory management, later,
> it might grow, if/when some other drivers will adopt it as well.
> 
> We will first change the NNP-I driver to use this framework.
> The GNA driver will wait for this API to be accepted and only then will
> adopt it and request to upstream.

Great, can you also look into what it would take to move the habanna
code to this new api as well?  A new api doesn't mean much if there is
only one user :)

thanks,

greg k-h