Re: [PATCH] sched, fair: try to prevent migration thread from preempting non-cfs task

[Valentin Schneider]

On 15/06/21 17:45, Vincent Guittot wrote:
> On Tue, 15 Jun 2021 at 16:55, Valentin Schneider
> <valentin.schneider@xxxxxxx> wrote:
>> This can be summarized as in the below, no?
>>
>>                         /*
>>                          * Don't cause a higher-than-CFS task to be preempted by
>>                          * the CPU stopper.
>>                          */
>
> IMO, it's worth keeping the explanation that we are there because:
> - a CFS task that was running during the 1st step :  if
> (busiest->nr_running > 1) { ...
> so we didn't pull the task
> - but it has been preempted while lb was deciding if it needs an
> active load balance
>
> so maybe something like:
>                          /*
>                           * Don't kick the active_load_balance_cpu_stop,
>                           * if the CFS task has been preempted by higher
>                           * priority task in the meantime.
>                          */
>

Ack