[PATCH] regulator: rt6160: Fix setting suspend voltage

From: Axel Lin
Date: Tue Jun 15 2021 - 21:18:38 EST


The vsel active level is for the normal voltage, the opposite level is
the suspend voltage.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
---
Hi ChiYuan,
I think fix it this way make the intention more clear.

drivers/regulator/rt6160-regulator.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/rt6160-regulator.c b/drivers/regulator/rt6160-regulator.c
index ccd023da4318..5d7b0e7ad69a 100644
--- a/drivers/regulator/rt6160-regulator.c
+++ b/drivers/regulator/rt6160-regulator.c
@@ -128,13 +128,19 @@ static unsigned int rt6160_get_mode(struct regulator_dev *rdev)
static int rt6160_set_suspend_voltage(struct regulator_dev *rdev, int uV)
{
struct regmap *regmap = rdev_get_regmap(rdev);
+ unsigned int suspend_vsel_reg;
int vsel;

vsel = regulator_map_voltage_linear(rdev, uV, uV);
if (vsel < 0)
return vsel;

- return regmap_update_bits(regmap, rdev->desc->vsel_reg,
+ if (rdev->desc->vsel_reg == RT6160_REG_VSELL)
+ suspend_vsel_reg = RT6160_REG_VSELH;
+ else
+ suspend_vsel_reg = RT6160_REG_VSELL;
+
+ return regmap_update_bits(regmap, suspend_vsel_reg,
RT6160_VSEL_MASK, vsel);
}

--
2.25.1