Re: [PATCH] vmxnet3: prevent building with 256K pages

[Christophe Leroy]

Le 16/06/2021 à 07:21, Christoph Hellwig a écrit :
> On Tue, Jun 15, 2021 at 02:41:34PM +0200, Christophe Leroy wrote:
> > Maybe we should also exclude hexagon, same as my patch on BTRFS https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a16c31f3caf448dda5d9315e056585b6fafc22c5.1623302442.git.christophe.leroy@xxxxxxxxxx/
>
> Maybe we really need common config symbols for the page size instead of
> all these hacks..

I agree.

Today we have:

arch/hexagon/Kconfig:config PAGE_SIZE_4KB
arch/hexagon/Kconfig:config PAGE_SIZE_16KB
arch/hexagon/Kconfig:config PAGE_SIZE_64KB
arch/hexagon/Kconfig:config PAGE_SIZE_256KB
arch/mips/Kconfig:config PAGE_SIZE_4KB
arch/mips/Kconfig:config PAGE_SIZE_8KB
arch/mips/Kconfig:config PAGE_SIZE_16KB
arch/mips/Kconfig:config PAGE_SIZE_32KB
arch/mips/Kconfig:config PAGE_SIZE_64KB
arch/sh/mm/Kconfig:config PAGE_SIZE_4KB
arch/sh/mm/Kconfig:config PAGE_SIZE_8KB
arch/sh/mm/Kconfig:config PAGE_SIZE_16KB
arch/sh/mm/Kconfig:config PAGE_SIZE_64KB


I think we should convert all other architectures to that syntax.

Christophe