Re: [PATCH V3] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

From: sbhanu
Date: Wed Jun 16 2021 - 01:55:14 EST


On 2021-06-16 05:38, Bjorn Andersson wrote:
On Tue 15 Jun 03:56 CDT 2021, sbhanu@xxxxxxxxxxxxxx wrote:

On 2021-06-14 17:00, sbhanu@xxxxxxxxxxxxxx wrote:
> On 2021-06-11 09:12, Bjorn Andersson wrote:
> > On Wed 09 Jun 10:20 CDT 2021, Shaik Sajida Bhanu wrote:
[..]
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
[..]
> > > + sdhc_1: sdhci@7c4000 {
[..]
> > > + sdhc1_opp_table: sdhc1-opp-table {
> >
> > No need for "sdhc1-" in the node name.
> ok
Hi,

For Sd card also we have opp-table info so if we remove "sdhc1-" here and
"sdhc2-" in Sd crad opp table we may have dublicate nodes so,
it is better to keep sdhc1 and sdhc2 in node numbers right.


Are you saying that /soc/sdhci@7c4000/opp-table needs to have a unique
name to not collide with /soc/sdhci@8804000/opp-table?

Regards,
Bjorn

yes

Thanks,
Sajida