Re: [PATCH 0/7] Fixup unused variables and warnings
From: Phillip Potter
Date: Wed Jun 16 2021 - 03:58:45 EST
On Wed, Jun 16, 2021 at 09:24:25AM +0200, Greg KH wrote:
> On Tue, Jun 15, 2021 at 11:36:00PM +0100, Phillip Potter wrote:
> > This series fixes an empty goto label by removing it and converting its
> > associated goto to a return. It also changes a decrement operator to
> > prefix to make it clearer, and provide expected behaviour. Finally, it
> > removes a lot of unused variables warned about by the kernel test robot,
> > which are a result of my previous DBG_88E removal series, and removes an
> > entire function as well which is surplus to requirements.
> >
> > Phillip Potter (7):
> > staging: rtl8188eu: remove empty label from
> > mlmeext_joinbss_event_callback
> > staging: rtl8188eu: use prefix decrement operator on trycnt variable
> > staging: rtl8188eu: remove unused variables from core/rtw_efuse.c
> > staging: rtl8188eu: remove unused variables from core/rtw_mlme_ext.c
> > staging: rtl8188eu: remove unused variable from os_dep/ioctl_linux.c
> > staging: rtl8188eu: remove unused variables from hal/rtl8188e_cmd.c
> > staging: rtl8188eu: remove _dbg_dump_tx_info function
>
> In the future, can you use "staging: rtl8188eu:" on the prefix of your
> 0/X email so these can be caught easier by those of us who filter on
> stuff like this?
>
> And thanks for fixing these so quickly, I'll go apply them now.
>
> thanks,
>
> greg k-h
Dear Greg,
Yes, absolutely, my apologies. I don't know why I wasn't doing this
already, seems obvious in hindsight - I put it down to my brain
malfunctioning :-) Many thanks for taking the patches.
Regards,
Phil