Re: [PATCH v11 28/33] mm/filemap: Add folio_wait_bit()

From: David Howells
Date: Wed Jun 16 2021 - 06:34:39 EST


Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> Rename wait_on_page_bit() to folio_wait_bit(). We must always wait on
> the folio, otherwise we won't be woken up due to the tail page hashing
> to a different bucket from the head page.
>
> This commit shrinks the kernel by 770 bytes, mostly due to moving
> the page waitqueue lookup into folio_wait_bit_common().
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>