Re: [PATCH] afs: fix no return statement in function returning non-void

From: Linus Torvalds
Date: Wed Jun 16 2021 - 10:34:40 EST


On Wed, Jun 16, 2021 at 5:56 AM Tom Rix <trix@xxxxxxxxxx> wrote:
>
> A fix is to use the __noreturn attribute on this function

That's certainly a better thing. It would be better yet to figure out
why BUG() didn't do it automatically.

Without CONFIG_BUG, it looks like powerpc picks up

#ifndef HAVE_ARCH_BUG
#define BUG() do {} while (1)

which should still make it pointless to have the return. But I might
have missed something.

Linus