Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation

From: Ido Schimmel
Date: Wed Jun 16 2021 - 11:39:29 EST


On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote:
> + debugfs_create_bool("fail_trap_counter_get", 0600,

The test is doing:

echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get

And fails with:

./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//fail_trap_drop_counter_get: Permission denied

Please fix netdevsim to instantiate the correct file and avoid
submitting new tests without running them first.


> + nsim_dev->ddir,
> + &nsim_dev->fail_trap_counter_get);
> nsim_udp_tunnels_debugfs_create(nsim_dev);
> return 0;