Re: [PATCH] ramfs: skip mknod if inode already exists.【请注意,邮件由viro@xxxxxxxxxxxxxxxx代发】

From: Chen Li
Date: Wed Jun 16 2021 - 21:14:09 EST


On Wed, 16 Jun 2021 20:16:58 +0800,
Al Viro wrote:
>
> On Wed, Jun 16, 2021 at 10:53:12AM +0800, Chen Li wrote:
> >
> > It's possible we try to mknod a dentry, which have
> > already bound to an inode, just skip it.
>
> Caller should have checked may_create(), which includes EEXIST handling.
> NAKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Don't know may_create before, thanks!
>
> Incidentally, if it ever had been called that way, your variant would
> leak inode. Not the main problem, though...
>
>