[PATCH -next v2] clk: renesas: fix return value and unused assignment

From: Yang Li
Date: Wed Jun 16 2021 - 22:22:15 EST


Currently the function returns NULL on error, so exact error code is lost.
This patch changes return convention of the function to use ERR_PTR()
on error instead.

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
---

Change in v2:
--simply "return ERR_PTR(-ENOMEM);"

drivers/clk/renesas/renesas-rzg2l-cpg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/renesas/renesas-rzg2l-cpg.c b/drivers/clk/renesas/renesas-rzg2l-cpg.c
index 5009b9e..d46fffd 100644
--- a/drivers/clk/renesas/renesas-rzg2l-cpg.c
+++ b/drivers/clk/renesas/renesas-rzg2l-cpg.c
@@ -182,8 +182,7 @@ static unsigned long rzg2l_cpg_pll_clk_recalc_rate(struct clk_hw *hw,

pll_clk = devm_kzalloc(dev, sizeof(*pll_clk), GFP_KERNEL);
if (!pll_clk) {
- clk = ERR_PTR(-ENOMEM);
- return NULL;
+ return ERR_PTR(-ENOMEM);
}

parent_name = __clk_get_name(parent);
--
1.8.3.1