Re: [PATCH] afs: fix tracepoint string placement with built-in AFS

From: Steven Rostedt
Date: Thu Jun 17 2021 - 09:37:30 EST


On Thu, 17 Jun 2021 13:04:49 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > Looks fine to me, and even saves 4 bytes on 64 bit machines (events are
> > rounded up to 4 byte increments, so the u16 is no different than a u32
> > here).
>
> Can I put that down as a Reviewed-by?

Sure. I was going to recommend consolidating the mappings a bit more to
have the enums and numbers defined in a single macro, but then I saw that
it matches the rest of the header file, and to do the consolidation would
require modifying the existing code, which I thought wasn't worth the
effort.

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve