Re: [PATCH -next v5] media: staging: atomisp: use list_splice_init in atomisp_compat_css20.c

[libaokun (A)]

Thank you for your advice.

I'm about to send a patch v6 with the changes suggested by you.

Best Regards.


在 2021/6/17 21:26, Andy Shevchenko 写道:
> On Thu, Jun 17, 2021 at 08:53:57PM +0800, Baokun Li wrote:
> > Using list_splice_init() instead of entire while-loops
> > in atomisp_compat_css20.c.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
> > ---
> > V1->V2:
> > 	CC mailist
> > V2->V3:
> >          Using list_move_tail() -> Using list_splice_init()
> > V3->V4:
> >          Remove redundant 'asd->'
> > V4->V5:
> >          Add the version information for 'V3->V4:'
> What about
>
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2107:31: warning: unused variable 'md_buf' [-Wunused-variable]
> 2107 |  struct atomisp_metadata_buf *md_buf;
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2106:26: warning: unused variable 'dis_buf' [-Wunused-variable]
> 2106 |  struct atomisp_dis_buf *dis_buf;
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2105:26: warning: unused variable 's3a_buf' [-Wunused-variable]
> 2105 |  struct atomisp_s3a_buf *s3a_buf;
>
> ?