Re: [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390

From: Nick Desaulniers
Date: Thu Jun 17 2021 - 15:59:37 EST


On Thu, Jun 17, 2021 at 12:32 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> clang versions prior to the current development version of 13.0.0 cannot
> compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair
> instead of register asm") and the s390 maintainers do not intend to work
> around this in the kernel. Codify this in scripts/min-tool-version.sh
> similar to arm64 with GCC 5.1.0 so that there are no reports of broken
> builds.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>

Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

> ---
>
> This should probably go through the s390 tree with Masahiro's ack.
>
> scripts/min-tool-version.sh | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index d22cf91212b0..319f92104f56 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -30,7 +30,12 @@ icc)
> echo 16.0.3
> ;;
> llvm)
> - echo 10.0.1
> + # https://lore.kernel.org/r/YMtib5hKVyNknZt3@osiris/
> + if [ "$SRCARCH" = s390 ]; then
> + echo 13.0.0
> + else
> + echo 10.0.1
> + fi
> ;;
> *)
> echo "$1: unknown tool" >&2
>
> base-commit: 7d9c6b8147bdd76d7eb2cf6f74f84c6918ae0939
> --
> 2.32.0.93.g670b81a890
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210617193139.856957-1-nathan%40kernel.org.



--
Thanks,
~Nick Desaulniers