Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings

From: Martin Blumenstingl
Date: Thu Jun 17 2021 - 18:30:21 EST

Hi Rob,

On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@xxxxxxxxxx> wrote:
> > +description: |+
> > + The HDMI TX PHY node should be the child of a syscon node with the
> > + required property:
> > +
> > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"
> Is there a sub range of registers for this functionality in
> "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.
yes, for this part of the HHI registers there's a dedicated sub range.
I'll add a reg property with register offset and size

one question about .dts validation: at least the clock controller
(which is also a sub-node of this) does not have a dedicated sub
Is it still OK in this case to set #size-cells = <1> and
#address-cells = <1> in the HHI node?

Best regards,