Re: [PATCH] locking/lockdep: correct the description error for check_redundant()

[Xiongwei Song]

On Thu, Jun 17, 2021 at 11:17 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> On Thu, Jun 17, 2021 at 11:05:23PM +0800, Xiongwei Song wrote:
> > From: Xiongwei Song <sxwjean@xxxxxxxxx>
> >
> > If there is no matched result, check_redundant() will return BFS_RNOMATCH.
> >
> > Signed-off-by: Xiongwei Song <sxwjean@xxxxxxxxx>
>
> Good catch!
>
> Nit: you may want to capitalize the first letter after subsystem tag in
> the patch title, like:
>
>         "locking/lockdep: Correct ..."

Ok. Will update the patch.

>
> Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx>

Thank you.

Regards,
Xiongwei
>
> Regards,
> Boqun
>
> > ---
> >  kernel/locking/lockdep.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index cfe0f4374594..1f126ca7fbd7 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> >   * <target> or not. If it can, <src> -> <target> dependency is already
> >   * in the graph.
> >   *
> > - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> > + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> >   * any error appears in the bfs search.
> >   */
> >  static noinline enum bfs_result
> > --
> > 2.30.2
> >