Re: [PATCH] fs: Return raw xattr for security.* if there is size disagreement with LSMs
From: Paul Moore
Date: Thu Jun 17 2021 - 23:19:15 EST
On Thu, Jun 17, 2021 at 11:28 AM Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
> On Thu, 2021-06-17 at 07:09 +0000, Roberto Sassu wrote:
...
> > An alternative would be to do the EVM verification twice if the
> > first time didn't succeed (with vfs_getxattr_alloc() and with the
> > new function that behaves like vfs_getxattr()).
>
> Unfortunately, I don't see an alternative.
... and while unfortunate, the impact should be non-existant if you
are using the right tools to label files or ensuring that you are
formatting labels properly if doing it by hand.
Handling a corner case is good, but I wouldn't add a lot of code
complexity trying to optimize it.
--
paul moore
www.paul-moore.com