Re: [PATCH 4/4] KVM: x86: Simplify logic to handle lack of host NX support

[Paolo Bonzini]

On 16/06/21 01:33, Sean Christopherson wrote:
> > It would be nice if we chose one consistent approach to dealing with
> > invalid guest CPUID information and stuck with it. Silently modifying
> > the table provided by userspace seems wrong to me. I much prefer the
> > kvm_check_cpuid approach of telling userspace that the guest CPUID
> > information is invalid. (Of course, once we return -EINVAL for more
> > than one field, good luck figuring out which field is invalid!)
> Yeah.  I suspect this one can be dropped if EFER.NX is required for everything
> except EPT, but I didn't fully grok the problem that this was fixing, and it's
> such an esoteric case that I both don't care and am terrified of breaking some
> bizarre case.

It's dating back to 2007 when EPT didn't even exist, I would just drop it.

Paolo