Re: [PATCH v11 11/18] virtio/vsock: dequeue callback for SOCK_SEQPACKET

From: Stefano Garzarella
Date: Fri Jun 18 2021 - 10:45:03 EST


On Fri, Jun 18, 2021 at 09:51:44AM -0400, Michael S. Tsirkin wrote:
On Fri, Jun 18, 2021 at 03:44:23PM +0200, Stefano Garzarella wrote:
Hi Arseny,
the series looks great, I have just a question below about
seqpacket_dequeue.

I also sent a couple a simple fixes, it would be great if you can review
them:
https://lore.kernel.org/netdev/20210618133526.300347-1-sgarzare@xxxxxxxxxx/

So given this was picked into net next, what's the plan? Just make spec
follow code? We can wait and see, if there are issues with the spec just
remember to mask the feature before release.

Yep, the spec patches was already posted, but not merged yet: https://lists.oasis-open.org/archives/virtio-comment/202105/msg00017.html

The changes are quite small and they are aligned with the current implementation.

Anyway, I perfectly agree with you about waiting and mask it before v5.14 release if there are any issue.

Thanks,
Stefano