Re: [PATCH V4 12/12] trace/osnoise: Support hotplug operations

[Steven Rostedt]

On Tue, 15 Jun 2021 11:28:51 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:

> @@ -1566,7 +1627,14 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count,
>  		osnoise_tracer_stop(tr);
>  
>  	mutex_lock(&interface_lock);
> +	/*
> +	 * osnoise_cpumask is ready by CPU hotplug operations.

I don't understand the usage of "ready" above. Lost in translation?

	 * osnoise_cpumask is updated by CPU hotplug operations.

?

-- Steve


> +	 */
> +	get_online_cpus();
> +
>  	cpumask_copy(&osnoise_cpumask, osnoise_cpumask_new);
> +
> +	put_online_cpus();
>  	mutex_unlock(&interface_lock);
>