Re: [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()

[James Smart]

On 6/16/2021 11:31 PM, Nathan Chancellor wrote:
> clang warns:
>
> drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
> 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                                (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
>                                 ~~~~~~^~~
>
> buf is an array in the middle of a struct so deferencing it is not a
> problem as long as ctx is not NULL. Eliminate the check, which fixes the
> warning.
>
> Fixes: 580c0255e4ef ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1398
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
>   drivers/scsi/elx/efct/efct_hw.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Thanks!

Reviewed-by: James Smart <jsmart2021@xxxxxxxxx>

-- james